[
https://issues.apache.org/jira/browse/BEAM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752972#comment-15752972
]
ASF GitHub Bot commented on BEAM-1153:
--------------------------------------
GitHub user peihe opened a pull request:
https://github.com/apache/incubator-beam/pull/1637
[BEAM-1153] GcsUtil: use non-batch API for single file size requests.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peihe/incubator-beam release-0.4.0-incubating
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1637
----
commit 58601f8c69b97dbdd9087b27c356c50bca7a1c8b
Author: Pei He <pe...@google.com>
Date: 2016-12-14T02:29:17Z
[BEAM-1153] GcsUtil: use non-batch API for single file size requests.
----
> GcsUtil needs to set timeout and retry explicitly in BatchRequest.
> ------------------------------------------------------------------
>
> Key: BEAM-1153
> URL: https://issues.apache.org/jira/browse/BEAM-1153
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Pei He
> Assignee: Pei He
> Priority: Blocker
>
> Non-batch requests uses RetryHttpRequestInitializer, which set read timeout
> as 80 seconds, and does more retries.
> Google Cloud auto generated Json library doesn't set HttpRequestInitializer
> for batch requests.
> GcsUtil uses storageClient.batch(), and it is defined in here:
> https://github.com/vparfonov/google-api-java-client/blob/master/google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClient.java#L256
> Without the HttpRequestInitializer, the default read timeout is 20 seconds.
> Possible fix is: https://github.com/apache/incubator-beam/pull/1608
> In additional, we can partially rollback
> https://github.com/apache/incubator-beam/pull/1359 to keep using non-batch
> API for fileSize() for single files. This will make sure existing code will
> keep work as the same way.
> PR: https://github.com/apache/incubator-beam/pull/1611
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
