This is an automated email from the ASF dual-hosted git repository.
popduke pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/bifromq.git
The following commit(s) were added to refs/heads/main by this push:
new 7c876521 Add exception handling for ProxyProtocolHandler and reduce
log level for MQTTPreludeHandler,closes #167 (#168)
7c876521 is described below
commit 7c8765211b73717079d18bdb10ab3737f7d38f5b
Author: zhangShunLin <[email protected]>
AuthorDate: Thu Aug 14 15:44:36 2025 +0800
Add exception handling for ProxyProtocolHandler and reduce log level for
MQTTPreludeHandler,closes #167 (#168)
---
.../java/org/apache/bifromq/mqtt/handler/MQTTPreludeHandler.java | 4 ++--
.../org/apache/bifromq/mqtt/handler/ProxyProtocolHandler.java | 9 +++++++++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git
a/bifromq-mqtt/bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/MQTTPreludeHandler.java
b/bifromq-mqtt/bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/MQTTPreludeHandler.java
index 05010601..58e030e5 100644
---
a/bifromq-mqtt/bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/MQTTPreludeHandler.java
+++
b/bifromq-mqtt/bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/MQTTPreludeHandler.java
@@ -199,14 +199,14 @@ public class MQTTPreludeHandler extends
ChannelDuplexHandler {
ctx.pipeline().remove(this);
break;
default:
- log.warn("Unsupported protocol version: {}",
connectMessage.variableHeader().version());
+ log.debug("Unsupported protocol version: {}",
connectMessage.variableHeader().version());
}
}
@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
// simple strategy: shutdown the channel directly
- log.warn("ctx: {}, cause:", ctx, cause);
+ log.debug("ctx: {}, cause:", ctx, cause);
eventCollector.report(getLocal(ChannelError.class).peerAddress(remoteAddr).cause(cause));
ctx.channel().close();
}
diff --git
a/bifromq-mqtt/bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/ProxyProtocolHandler.java
b/bifromq-mqtt/bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/ProxyProtocolHandler.java
index 1dc99c53..ee029c34 100644
---
a/bifromq-mqtt/bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/ProxyProtocolHandler.java
+++
b/bifromq-mqtt/bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/ProxyProtocolHandler.java
@@ -24,6 +24,8 @@ import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelInboundHandlerAdapter;
import io.netty.channel.ChannelPipeline;
import io.netty.handler.codec.haproxy.HAProxyMessage;
+import lombok.extern.slf4j.Slf4j;
+
import java.net.InetSocketAddress;
import java.util.Iterator;
import java.util.Map;
@@ -31,6 +33,7 @@ import java.util.Map;
/**
* This handler is used to parse the HAProxy protocol message and extract the
real IP and port of the client.
*/
+@Slf4j
public class ProxyProtocolHandler extends ChannelInboundHandlerAdapter {
@Override
@@ -73,4 +76,10 @@ public class ProxyProtocolHandler extends
ChannelInboundHandlerAdapter {
ctx.pipeline().remove(this);
}
}
+
+ @Override
+ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause)
throws Exception {
+ log.debug("ctx: {}, cause:", ctx, cause);
+ }
+
}