Gujiawei-Edinburgh commented on code in PR #188:
URL: https://github.com/apache/bifromq/pull/188#discussion_r2510757482


##########
base-env/base-env-provider/src/main/java/org/apache/bifromq/baseenv/ZeroCopyParser.java:
##########
@@ -43,4 +44,17 @@ public static <T> T parse(ByteString bytes, Parser<T> 
parser) throws InvalidProt
         input.enableAliasing(true);

Review Comment:
   From this PR, zero-copy parser is used more widely. How about the case of 
direct buffer memory usage? And will it cause OOM when the parsing is extremly 
frequent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to