popduke commented on PR #204: URL: https://github.com/apache/bifromq/pull/204#issuecomment-3641176566
First of all, thank you for voluntarily picking up a TODO. However, I don’t think this change is necessary. The TODO you selected is somewhat outdated (it should have been removed). The config-change operation exposed through the BaseKV client requires tight coordination between the WAL and the FSM, and the interaction no longer depends on routing config-change requests among Raft peers. Also, this change touches a very low-level part of the system and would imply modifications to the cluster communication protocol, which could have compatibility implications. It’s not something suitable for a direct PR. If you believe the change is needed, I would suggest starting with a Proposal on the community side first (https://cwiki.apache.org/confluence/display/BIFROMQ/BIP-000-Template). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
