(bigtop-manager) branch main updated: BIGTOP-4470: Kafka should read env file when starting (#248)

[wuzhiguo]

This is an automated email from the ASF dual-hosted git repository.

wuzhiguo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/bigtop-manager.git


The following commit(s) were added to refs/heads/main by this push:
     new 50c1365e BIGTOP-4470: Kafka should read env file when starting (#248)
50c1365e is described below

commit 50c1365e68c8841e6dd5aa480d76047007996784
Author: Chenhuab <72728008+chenh...@users.noreply.github.com>
AuthorDate: Mon Jul 21 18:48:17 2025 +0800

    BIGTOP-4470: Kafka should read env file when starting (#248)
---
 .../stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml   | 5 -----
 .../stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml   | 5 -----
 .../bigtop/manager/stack/bigtop/v3_3_0/kafka/KafkaBrokerScript.java  | 2 +-
 3 files changed, 1 insertion(+), 11 deletions(-)

diff --git 
a/bigtop-manager-server/src/main/resources/stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml
 
b/bigtop-manager-server/src/main/resources/stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml
index e51666ce..ac167a78 100644
--- 
a/bigtop-manager-server/src/main/resources/stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml
+++ 
b/bigtop-manager-server/src/main/resources/stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml
@@ -56,11 +56,6 @@ export JAVA_HOME=${java_home!}
 <#noparse>export PATH=$PATH:${JAVA_HOME}/bin</#noparse>
 export PID_DIR=${kafka_pid_dir!}
 export LOG_DIR=${kafka_log_dir!}
-<#if security_enabled >
-export KAFKA_OPTS="-Djavax.security.auth.useSubjectCredsOnly=false 
{{kafka_kerberos_params}}"
-<#else>
-export KAFKA_OPTS={{kafka_kerberos_params}}
-</#if>
 export CLASSPATH=$CLASSPATH:${kafka_conf_dir}
 ]]>
       </value>
diff --git 
a/bigtop-manager-server/src/test/resources/stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml
 
b/bigtop-manager-server/src/test/resources/stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml
index e51666ce..ac167a78 100644
--- 
a/bigtop-manager-server/src/test/resources/stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml
+++ 
b/bigtop-manager-server/src/test/resources/stacks/bigtop/3.3.0/services/kafka/configuration/kafka-env.xml
@@ -56,11 +56,6 @@ export JAVA_HOME=${java_home!}
 <#noparse>export PATH=$PATH:${JAVA_HOME}/bin</#noparse>
 export PID_DIR=${kafka_pid_dir!}
 export LOG_DIR=${kafka_log_dir!}
-<#if security_enabled >
-export KAFKA_OPTS="-Djavax.security.auth.useSubjectCredsOnly=false 
{{kafka_kerberos_params}}"
-<#else>
-export KAFKA_OPTS={{kafka_kerberos_params}}
-</#if>
 export CLASSPATH=$CLASSPATH:${kafka_conf_dir}
 ]]>
       </value>
diff --git 
a/bigtop-manager-stack/bigtop-manager-stack-bigtop/src/main/java/org/apache/bigtop/manager/stack/bigtop/v3_3_0/kafka/KafkaBrokerScript.java
 
b/bigtop-manager-stack/bigtop-manager-stack-bigtop/src/main/java/org/apache/bigtop/manager/stack/bigtop/v3_3_0/kafka/KafkaBrokerScript.java
index 93012ae3..920377db 100644
--- 
a/bigtop-manager-stack/bigtop-manager-stack-bigtop/src/main/java/org/apache/bigtop/manager/stack/bigtop/v3_3_0/kafka/KafkaBrokerScript.java
+++ 
b/bigtop-manager-stack/bigtop-manager-stack-bigtop/src/main/java/org/apache/bigtop/manager/stack/bigtop/v3_3_0/kafka/KafkaBrokerScript.java
@@ -57,7 +57,7 @@ public class KafkaBrokerScript extends AbstractServerScript {
         KafkaParams kafkaParams = (KafkaParams) params;
 
         String cmd = MessageFormat.format(
-                "{0}/bin/kafka-server-start.sh {0}/config/server.properties > 
/dev/null 2>&1 & echo -n $!>{1}",
+                "source {0}/config/kafka-env.sh ; 
{0}/bin/kafka-server-start.sh {0}/config/server.properties > /dev/null 2>&1 & 
echo -n $!>{1}",
                 kafkaParams.serviceHome(), kafkaParams.getKafkaPidFile());
         try {
             return LinuxOSUtils.sudoExecCmd(cmd, kafkaParams.user());