#667: Error rendering forbidden pages
------------------------+---------------------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  review
  Priority:  blocker    |  Milestone:  Release 8
 Component:  ui design  |    Version:  0.7.0
Resolution:             |   Keywords:  permissions, chrome
------------------------+---------------------------------

Comment (by rjollos):

 The patch appears to be effectively the same as the one in comment:3. Is
 there a difference I'm not seeing, or just style differences? I'm fine
 with using the `.get('mainnav', []))` since I think it's cleaner.

 Is the `setdefault` needed? There won't be any iteration if `mainnav`
 isn't in the dictionary, so it doesn't appear that the line with
 `setdefault` would even be hit.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/667#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Reply via email to