This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new fe012e3 Increase page size for fetching github labels
fe012e3 is described below
commit fe012e31248a68a53b3976babaa32dbd51fc8e89
Author: Sijie Guo <[email protected]>
AuthorDate: Thu Jan 18 11:11:58 2018 -0800
Increase page size for fetching github labels
Descriptions of the changes in this PR:
*Problem*
The default page size for github api is 30 items. The number of labels at
bookkeeper are more than 30 items, so `type/task` is not showing up at merge
script.
*Solution*
This change is to bump the page size to 100 items.
Author: Sijie Guo <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>
This closes #1013 from sijie/increase_page_size
---
dev/bk-merge-pr.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dev/bk-merge-pr.py b/dev/bk-merge-pr.py
index 7ef97da..8c3415e 100755
--- a/dev/bk-merge-pr.py
+++ b/dev/bk-merge-pr.py
@@ -57,6 +57,8 @@ DEV_BRANCH_NAME = os.environ.get("DEV_BRANCH_NAME", "master")
JIRA_USERNAME = os.environ.get("JIRA_USERNAME", "")
# ASF JIRA password
JIRA_PASSWORD = os.environ.get("JIRA_PASSWORD", "")
+# Github API page size
+GITHUB_PAGE_SIZE = os.environ.get("GH_PAGE_SIZE", "100")
# OAuth key used for issuing requests against the GitHub API. If this is not
defined, then requests
# will be unauthenticated. You should only need to configure this if you find
yourself regularly
# exceeding your IP's unauthenticated request rate limit. You can create an
OAuth key at
@@ -144,7 +146,7 @@ def get_milestones():
return
get_json("https://api.github.com/repos/%s/%s/milestones?state=open&sort=due_on&direction=asc";
% (GITHUB_USER, PROJECT_NAME))
def get_all_labels():
- result = get_json("https://api.github.com/repos/%s/%s/labels"; %
(GITHUB_USER, PROJECT_NAME))
+ result = get_json("https://api.github.com/repos/%s/%s/labels?per_page=%s";
% (GITHUB_USER, PROJECT_NAME, GITHUB_PAGE_SIZE))
return map(lambda x: x['name'], result)
# merge the requested PR and return the merge hash
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
