dlg99 commented on code in PR #3620:
URL: https://github.com/apache/bookkeeper/pull/3620#discussion_r1015902463
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java:
##########
@@ -266,6 +266,10 @@ public void run() {
// We are about to send. Check if we need to make an ensemble change
// because of delayed write errors
lh.maybeHandleDelayedWriteBookieFailure();
+ // This op maybe recycled during bookie failures
+ if (maybeRecycled()) {
Review Comment:
So maybeHandleDelayedWriteBookieFailure triggers something that recycles
this pending add op (I haven't looked that closely)?
Then the fix masks the problem.
One side of the problem is that lh becomes null / results in NPE later.
Another side of the problem is that pending add opp can be recycled and
immediately reused by another add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
