horizonzy commented on code in PR #3723:
URL: https://github.com/apache/bookkeeper/pull/3723#discussion_r1060325503
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ITopologyAwareEnsemblePlacementPolicy.java:
##########
@@ -122,6 +122,29 @@ T selectFromNetworkLocation(String networkLoc,
boolean fallbackToRandom)
throws BKException.BKNotEnoughBookiesException;
+ /**
+ * Select a node from a given network location.
+ *
+ * @param networkLoc
+ * network location
+ * @param excludeBookies
+ * exclude bookies set
+ * @param predicate
+ * predicate to apply
+ * @param ensemble
+ * ensemble
+ * @param fallbackToRandom
+ * fallbackToRandom
+ * @return the selected bookie.
+ * @throws BKException.BKNotEnoughBookiesException
+ */
+ T selectFromNetworkLocationWithPickCommonRackFirst(String networkLoc,
Review Comment:
Followed the method `selectFromNetworkLocation`; it's not a default method.
The `ZoneawareEnsemblePlacementPolicyImpl` implements the method and throws an
exception.
https://github.com/apache/bookkeeper/blob/405e72acf42bb1104296447ea8840d805094c787/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ZoneawareEnsemblePlacementPolicyImpl.java#L303-L309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
