zhaohaidao commented on code in PR #3620:
URL: https://github.com/apache/bookkeeper/pull/3620#discussion_r1082279230
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java:
##########
@@ -1769,7 +1769,7 @@ void handleUnrecoverableErrorDuringAdd(int rc) {
if (getLedgerMetadata().getState() ==
LedgerMetadata.State.IN_RECOVERY) {
// we should not close ledger if ledger is recovery mode
// otherwise we may lose entry.
- errorOutPendingAdds(rc);
+ executeOrdered(() -> errorOutPendingAdds(rc));
Review Comment:
@horizonzy I may not have explained it clearly. Although this is changed to
an async operation, this code block will never be executed, because when in
IN_RECOVERY mode, the method of ReadOnlyLedgerHandle must be called.
What do you think if I roll back the changes to LedgerHandle and only keep
the changes to ReadOnlyLedgerHandle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
