horizonzy commented on code in PR #3726:
URL: https://github.com/apache/bookkeeper/pull/3726#discussion_r1110964733
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java:
##########
@@ -1058,9 +1056,7 @@ public LedgerHandle createLedgerAdv(int ensSize, int
writeQuorumSize, int ackQuo
public void asyncCreateLedgerAdv(final int ensSize, final int
writeQuorumSize, final int ackQuorumSize,
final DigestType digestType, final byte[] passwd, final
CreateCallback cb, final Object ctx,
final Map<String, byte[]> customMetadata) {
- if (writeQuorumSize < ackQuorumSize) {
- throw new IllegalArgumentException("Write quorum must be larger
than ack quorum");
- }
+ checkLedgerCreationParameters(ensSize, writeQuorumSize, ackQuorumSize);
Review Comment:
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
