merlimat opened a new pull request, #3811:
URL: https://github.com/apache/bookkeeper/pull/3811

   ### Motivation
   
   In `DigestManager` there are several accesses to ThreadLocal variable per 
each entry processed.
   
   The reason is the mainly due to `DigestManager` API which exposes a stateful 
`update()` method which can be invoked multiple times and keeps the current 
checksum as a thread-local variable.
   
   If we exclude MAC digest which is 20 bytes, for other digests we can instead 
keep the current checksum in a local variable and pass it each time, avoiding 
all the thread-locals and also the need for writing the checksum result into a 
buffer.
   
   ### Benchmarks
   
   #### Before #3810 
   
   ```
   Benchmark                            (entrySize)   Mode  Cnt   Score   Error 
  Units
   DigestManagerBenchmark.verifyDigest           64  thrpt    3  13.450 ± 3.634 
 ops/us
   DigestManagerBenchmark.verifyDigest         1024  thrpt    3   7.908 ± 2.637 
 ops/us
   DigestManagerBenchmark.verifyDigest         4086  thrpt    3   3.233 ± 0.882 
 ops/us
   DigestManagerBenchmark.verifyDigest         8192  thrpt    3   1.846 ± 0.047 
 ops/us
   ```
   
   #### After #3810 
   
   ```
   Benchmark                            (entrySize)   Mode  Cnt   Score   Error 
  Units
   DigestManagerBenchmark.verifyDigest           64  thrpt    3  46.312 ± 7.414 
 ops/us
   DigestManagerBenchmark.verifyDigest         1024  thrpt    3  13.379 ± 1.069 
 ops/us
   DigestManagerBenchmark.verifyDigest         4086  thrpt    3   3.787 ± 0.059 
 ops/us
   DigestManagerBenchmark.verifyDigest         8192  thrpt    3   1.956 ± 0.052 
 ops/us
   ```
   
   #### After this change
   
   
   
   ```
   Benchmark                            (entrySize)   Mode  Cnt    Score   
Error   Units
   DigestManagerBenchmark.verifyDigest           64  thrpt    3  130.108 ± 
4.854  ops/us
   DigestManagerBenchmark.verifyDigest         1024  thrpt    3   17.744 ± 
0.238  ops/us
   DigestManagerBenchmark.verifyDigest         4086  thrpt    3    4.104 ± 
0.181  ops/us
   DigestManagerBenchmark.verifyDigest         8192  thrpt    3    2.050 ± 
0.066  ops/us
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to