wenbingshen commented on PR #3951:
URL: https://github.com/apache/bookkeeper/pull/3951#issuecomment-1541303788
> I have left some comments. I am not sure if this is adding cost on the hot
paths
IMO, the code below is the core hot path, active connections will get hits
in channels most of the time:
```java
public PerChannelBookieClientPool lookupClient(BookieId addr) {
PerChannelBookieClientPool clientPool = channels.getIfPresent(addr);
return clientPool;
}
```
A new connection will only be created when the bookie node is expanded or
restarted.
> can you please also add tests ?
I will add tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
