horizonzy commented on code in PR #3948:
URL: https://github.com/apache/bookkeeper/pull/3948#discussion_r1190134192
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:
##########
@@ -1036,6 +1036,9 @@ public EntryLogMetadata getEntryLogMetadata(long
entryLogId, AbstractLogCompacto
// entry log
try {
return extractEntryLogMetadataFromIndex(entryLogId);
+ } catch (FileNotFoundException ex) {
+ LOG.warn("Cannot find entry log file {}.log", entryLogId);
Review Comment:
The file entryLogId should be hex, we can get the log info by ex.getMessage()
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:
##########
@@ -1036,6 +1036,9 @@ public EntryLogMetadata getEntryLogMetadata(long
entryLogId, AbstractLogCompacto
// entry log
try {
return extractEntryLogMetadataFromIndex(entryLogId);
+ } catch (FileNotFoundException ex) {
+ LOG.warn("Cannot find entry log file {}.log", entryLogId);
+ throw new IOException(ex);
Review Comment:
Why wrap the FileNotFoundExpcetion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
