aloyszhang commented on code in PR #3329:
URL: https://github.com/apache/bookkeeper/pull/3329#discussion_r1194830852
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java:
##########
@@ -872,6 +869,9 @@ int shutdown(int exitCode) {
// Shutdown the EntryLogger which has the GarbageCollector
Thread running
ledgerStorage.shutdown();
+ // Shutdown Sync thread
+ syncThread.shutdown();
Review Comment:
Here may through exceptions when shutdown the `syncThread` which will call
`checkpoint` of ledgerStoreage, since we have already shut down the
ledgeerStorage before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
