hangc0276 commented on code in PR #3956:
URL: https://github.com/apache/bookkeeper/pull/3956#discussion_r1200244274
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -4010,6 +4012,25 @@ public boolean
isDataIntegrityStampMissingCookiesEnabled() {
return this.getBoolean(DATA_INTEGRITY_COOKIE_STAMPING_ENABLED, false);
}
+
+ /**
+ * When this config is set to true,if we replay journal failed, we will
skip.
+ * @param skipReplayJournalInvalidRecord
+ * @return
+ */
+ public ServerConfiguration setSkipReplayJournalInvalidRecord(boolean
skipReplayJournalInvalidRecord) {
+ this.setProperty(SKIP_REPLAY_JOURNAL_INVALID_RECORD,
+ Boolean.toString(skipReplayJournalInvalidRecord));
+ return this;
+ }
+
+ /**
+ * @see #isSkipReplayJournalInvalidRecord .
+ */
+ public boolean isSkipReplayJournalInvalidRecord() {
+ return this.getBoolean(SKIP_REPLAY_JOURNAL_INVALID_RECORD, false);
Review Comment:
Even though the previous default behavior is `false`, I changed the default
value to `true`, because I think it's valuable to skip the the invalid record
instead of make the bookie node can't start up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
