wenbingshen commented on code in PR #3965:
URL: https://github.com/apache/bookkeeper/pull/3965#discussion_r1206485174
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:
##########
@@ -528,6 +528,7 @@ public boolean removeEntryLog(long entryLogId) {
}
if (!entryLogFile.delete()) {
Review Comment:
I think the first method is better, simply log and return true, throw
IllegalStateException changes the previous behavior, users may be less willing
to care about the reason for its non-existence when cleaning up the outdated
entryLogFile. And keep the original behavior can avoid introducing possible
bugs. Here, we just make `entryLogMetaMap.remove` work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
