horizonzy commented on issue #3971: URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1568449729
> > Could you please tell me how you implemented it? Now we check the ledger placement policy when its metadata is closed. Did you change the source code to implement it? > > https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260 > > I change two part of source code, remove "if (!metadata.isClosed())" > > https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260 > > https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java#L391 Make sense. There is one thing need to pay attention: the last ensemble should not be checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
