tisonkun commented on PR #3979: URL: https://github.com/apache/bookkeeper/pull/3979#issuecomment-1588356983
> We can add a test to cover the recycle() case in the important place By comparing new objects with objects retrieved from the pool. Instead of testing the implementation, perhaps testing the performance a good idea - if missing recycling doesn't cause performance regression, that should be fine. Does BookKeeper have any kind of performance regression coverage now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
