Shawyeok commented on PR #4137: URL: https://github.com/apache/bookkeeper/pull/4137#issuecomment-1851219182
> Actually, the apply-config-from-env will go through the configuration file and only update the existing key with the format k=v. So I don't think it will update the log4j configuration file. Could you please paste your log4j configuration file as well? @zymap There is an edge case here. For example, with the log4j2.xml configuration below, <Console name="CONSOLE" and <Console name="CONSOLEMDC" are treated as having the same key due to their k=v pattern (here, it’s <Consolename). As a result, any configuration lines that appear later are discarded, thus breaking the validity of the XML format. https://github.com/apache/bookkeeper/blob/5be03cfdfb4dbe4ad37bd2502fe514d9b347cd26/conf/log4j2.xml#L30-L35 Here is a docker-compose file that can quickly reproduce the issue. You will see the error information mentioned in #4136. ```yaml version: '3' services: zk: image: zookeeper:3.8.1 bookie0: image: apache/bookkeeper:4.16.3 environment: - BK_zkServers=zk:2181 depends_on: - zk ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
