merlimat commented on code in PR #4195:
URL: https://github.com/apache/bookkeeper/pull/4195#discussion_r1472236106
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java:
##########
@@ -641,6 +642,29 @@ public Enumeration<LedgerEntry> readEntries(long
firstEntry, long lastEntry)
return SyncCallbackUtils.waitForResult(result);
}
+ /**
+ * Read a sequence of entries synchronously.
+ *
+ * @param startEntry
+ * start entry id
+ * @param maxCount
+ * the total entries count.
+ * @param maxSize
+ * the total entries size.
+ * @param failbackToSingleRead
Review Comment:
Shouldn't we always want to fallback, when the server does not support the
feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
