lhotari commented on PR #4196: URL: https://github.com/apache/bookkeeper/pull/4196#issuecomment-1924095343
> Bunch of test timed out so something is wrong. Yes, that was the WIP that I was working to fix. I have a fix, but since there are a lot of changes, it's possible that this will have be split into multiple PRs. I found an issue with Java9IntHash, but I haven't yet added a unit test to demonstrate the issue. > Would use of CompositeByteBuf's decompose() solve this issue? > Like > ((CompositeByteBuf) unwrapped).decompose(data.offset(), data.length()).forEach(..) No. There are multiple layers of wrappers and it's not safe to unwrap the wrappers. I hope the previous comment https://github.com/apache/bookkeeper/pull/4196#issuecomment-1920714720 clarifies this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
