wenbingshen commented on code in PR #4285:
URL: https://github.com/apache/bookkeeper/pull/4285#discussion_r1562113411
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1209,6 +1209,7 @@ private void writeAndFlush(final Channel channel,
}
} else {
nettyOpLogger.registerFailedEvent(MathUtils.elapsedNanos(startTime),
TimeUnit.NANOSECONDS);
+ errorOut(key);
Review Comment:
>
> In #4278, the PerChannelBookieClient#addEntryTimeoutNanos is enabled, So
you will see that 5 seconds(default timeout) passed after bk1 died, the step 9
trigger PendingAddOp timeout, then cause the issue in #4278.
>
I have a question, since we have a default thread to detect timeout requests
every 5 seconds and remove the timedout `CompletionKey` from
`completionObjects`, even if the write fails, will the timeout detection task
not remove the key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
