lhotari commented on code in PR #4289:
URL: https://github.com/apache/bookkeeper/pull/4289#discussion_r1567134245
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1180,6 +1180,7 @@ private void writeAndFlush(final Channel channel,
if (channel == null) {
LOG.warn("Operation {} failed: channel == null",
StringUtils.requestToString(request));
errorOut(key);
+ ReferenceCountUtil.release(request);
Review Comment:
I think it's the wrong thing to do generally in this method. I'll share a
new PR where I explain an alternative approach that handles both the V3
protocol and the UnsafeByteOperations issue and the issue that was found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
