lhotari commented on issue #791: URL: https://github.com/apache/bookkeeper/issues/791#issuecomment-2058949630
> I am not sure we can use pooled buffer, because when you use `UnsafeByteOperations` to wrap the underlying buffer, before this unsafe wrapped buffer being used by protobuf to convert it to netty channel, we might already release pooled buffer, which the underlying byte array or nio buffer might be used by other requests, which can potentially cause corruption. > > so I think using unpooled buffers with `UnsafeByteOperations` are much safer than using pooled buffers with `UnsafeByteOperations`. I have created #4293 to address this concern and to fix the issue that this PR #791 causes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
