(bookkeeper) branch master updated: improve: remove duplicate forceGarbageCollection setValue in run method (#4303)

[shoothzj]

This is an automated email from the ASF dual-hosted git repository.

shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new d7328a5b9b improve: remove duplicate forceGarbageCollection setValue 
in run method (#4303)
d7328a5b9b is described below

commit d7328a5b9b8319af01aee8f846178531bbece109
Author: ZhangJian He <shoot...@gmail.com>
AuthorDate: Mon Apr 29 13:48:07 2024 +0800

    improve: remove duplicate forceGarbageCollection setValue in run method 
(#4303)
    
    ### Motivation
    remove duplicate forceGarbageCollection setValue, it is redundant and 
error-prone. It's already seted in
    
    
https://github.com/apache/bookkeeper/blob/945cfa138f2b64f258d5b53a98505264085500f0/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java#L473-L478
    
    Signed-off-by: ZhangJian He <shoot...@gmail.com>
---
 .../java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java   | 6 ------
 1 file changed, 6 deletions(-)

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
index 1d04955583..e58064cfd9 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
@@ -398,12 +398,6 @@ public class GarbageCollectorThread implements Runnable {
         boolean suspendMinor = suspendMinorCompaction.get();
 
         runWithFlags(force, suspendMajor, suspendMinor);
-
-        if (force) {
-            // only set force to false if it had been true when the garbage
-            // collection cycle started
-            forceGarbageCollection.set(false);
-        }
     }
 
     public void runWithFlags(boolean force, boolean suspendMajor, boolean 
suspendMinor) {