This is an automated email from the ASF dual-hosted git repository.
nicoloboschi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 09a38e5192 chore: remove unused slf4j simpleLogger property (#4321)
09a38e5192 is described below
commit 09a38e5192bc487ce67c7b041bee7235f79b575c
Author: ZhangJian He <[email protected]>
AuthorDate: Tue Apr 30 21:16:36 2024 +0800
chore: remove unused slf4j simpleLogger property (#4321)
Signed-off-by: ZhangJian He <[email protected]>
---
.github/workflows/bk-ci.yml | 14 +++++++-------
.github/workflows/codeql.yml | 2 +-
tests/README.md | 10 +++++-----
tests/integration-tests-base-groovy/pom.xml | 5 -----
4 files changed, 13 insertions(+), 18 deletions(-)
diff --git a/.github/workflows/bk-ci.yml b/.github/workflows/bk-ci.yml
index 035c2c5e27..e22b728424 100644
--- a/.github/workflows/bk-ci.yml
+++ b/.github/workflows/bk-ci.yml
@@ -82,8 +82,8 @@ jobs:
- name: Validate pull request
if: steps.check_changes.outputs.docs_only != 'true'
run: |
- mvn -T 1C -B -nsu clean install -Ddistributedlog -DskipTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO
- mvn -T 1C -B -nsu apache-rat:check checkstyle:check spotbugs:check
package -Ddistributedlog -DskipTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO
+ mvn -T 1C -B -nsu clean install -Ddistributedlog -DskipTests
+ mvn -T 1C -B -nsu apache-rat:check checkstyle:check spotbugs:check
package -Ddistributedlog -DskipTests
- name: Check license files
if: steps.check_changes.outputs.docs_only != 'true'
@@ -234,14 +234,14 @@ jobs:
$GITHUB_WORKSPACE/dev/ci-tool pick_ubuntu_mirror
- name: Build with Maven
- run: mvn -B -nsu clean install -Pdocker -DskipTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO
+ run: mvn -B -nsu clean install -Pdocker -DskipTests
- name: Run metadata driver tests
- run: mvn -B -nsu -f metadata-drivers/pom.xml test -DintegrationTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO
+ run: mvn -B -nsu -f metadata-drivers/pom.xml test -DintegrationTests
- name: Run all integration tests (except backward compatibility tests)
run: |
- mvn -B -nsu -f tests/pom.xml test -DintegrationTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO -DredirectTestOutputToFile=false
-DtestRetryCount=0
+ mvn -B -nsu -f tests/pom.xml test -DintegrationTests
-DredirectTestOutputToFile=false -DtestRetryCount=0
- name: print JVM thread dumps when cancelled
if: cancelled()
@@ -319,7 +319,7 @@ jobs:
$GITHUB_WORKSPACE/dev/ci-tool pick_ubuntu_mirror
- name: Build with Maven
- run: mvn -B -nsu clean install -Pdocker -DskipTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO
+ run: mvn -B -nsu clean install -Pdocker -DskipTests
- name: Test current server with old clients
run: mvn -B -nsu -DbackwardCompatTests -pl
:backward-compat-current-server-old-clients test
@@ -471,7 +471,7 @@ jobs:
java-version: ${{ matrix.jdk_version }}
- name: Build with Maven
- run: mvn clean package -B -nsu -DskipBookKeeperServerTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO
+ run: mvn clean package -B -nsu -DskipBookKeeperServerTests
- name: print JVM thread dumps when cancelled
if: cancelled()
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index d0d5305dba..3c2d81b2d2 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -92,7 +92,7 @@ jobs:
- name: Validate pull request
if: steps.check_changes.outputs.docs_only != 'true'
run: |
- mvn -T 1C -B -nsu clean install -Ddistributedlog -DskipTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO
+ mvn -T 1C -B -nsu clean install -Ddistributedlog -DskipTests
- name: Perform CodeQL Analysis
if: steps.check_changes.outputs.docs_only != 'true'
diff --git a/tests/README.md b/tests/README.md
index 4d79d4b6d3..dff705c4bc 100644
--- a/tests/README.md
+++ b/tests/README.md
@@ -61,21 +61,21 @@ docker images | grep apachebookkeeper
```bash
# Run metadata driver tests
-mvn -f metadata-drivers/pom.xml test -DintegrationTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO -DredirectTestOutputToFile=false
-DtestRetryCount=0
+mvn -f metadata-drivers/pom.xml test -DintegrationTests
-DredirectTestOutputToFile=false -DtestRetryCount=0
# Run all integration tests
-mvn -f tests/pom.xml test -DintegrationTests
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO -DredirectTestOutputToFile=false
-DtestRetryCount=0
+mvn -f tests/pom.xml test -DintegrationTests -DredirectTestOutputToFile=false
-DtestRetryCount=0
```
### Running backward compatibility tests
```bash
# Test current server with old clients
-mvn -DbackwardCompatTests -pl :backward-compat-current-server-old-clients test
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO -DredirectTestOutputToFile=false
-DtestRetryCount=0
+mvn -DbackwardCompatTests -pl :backward-compat-current-server-old-clients test
-DredirectTestOutputToFile=false -DtestRetryCount=0
# Test progressive upgrade
-mvn -DbackwardCompatTests -pl :upgrade test
-Dorg.slf4j.simpleLogger.defaultLogLevel=INFO -DredirectTestOutputToFile=false
-DtestRetryCount=0
+mvn -DbackwardCompatTests -pl :upgrade test -DredirectTestOutputToFile=false
-DtestRetryCount=0
# Other backward compat tests
-mvn -DbackwardCompatTests -pl
:bc-non-fips,:hierarchical-ledger-manager,:hostname-bookieid,:old-cookie-new-cluster,:recovery-no-password,:upgrade-direct,:yahoo-custom-version
test -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO
-DredirectTestOutputToFile=false -DtestRetryCount=0
+mvn -DbackwardCompatTests -pl
:bc-non-fips,:hierarchical-ledger-manager,:hostname-bookieid,:old-cookie-new-cluster,:recovery-no-password,:upgrade-direct,:yahoo-custom-version
test -DredirectTestOutputToFile=false -DtestRetryCount=0
```
\ No newline at end of file
diff --git a/tests/integration-tests-base-groovy/pom.xml
b/tests/integration-tests-base-groovy/pom.xml
index 94e1861609..b1e3119f58 100644
--- a/tests/integration-tests-base-groovy/pom.xml
+++ b/tests/integration-tests-base-groovy/pom.xml
@@ -71,11 +71,6 @@
<argLine>-Xmx4G -Djava.net.preferIPv4Stack=true
${test.additional.args}</argLine>
<forkCount>1</forkCount>
<useSystemClassLoader>false</useSystemClassLoader>
- <systemPropertyVariables>
- <!-- only takes effect in later simpleLogger versions (1.7+) //-->
-
<org.slf4j.simpleLogger.logFile>System.out</org.slf4j.simpleLogger.logFile>
-
<org.slf4j.simpleLogger.showDateTime>true</org.slf4j.simpleLogger.showDateTime>
- </systemPropertyVariables>
</configuration>
</plugin>
