shoothzj commented on code in PR #4324:
URL: https://github.com/apache/bookkeeper/pull/4324#discussion_r1590018243
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -792,9 +792,6 @@ protected List<BookieNode>
selectRandomInternal(List<BookieNode> bookiesToSelect
Map<BookieNode, WeightedObject> rackMap = new HashMap<BookieNode,
WeightedObject>();
for (BookieNode n : bookiesToSelectFrom) {
- if (excludeBookies.contains(n)) {
- continue;
- }
Review Comment:
@hangc0276 IMHO, keeping input param `excludeBookies` and remove this if
clause is a little confusing. WDYT? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
