eolivelli commented on code in PR #4340:
URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590536094
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java:
##########
@@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long logId,
writeHeader(bcBuilder, writeBufferSize);
} else { // open an existing file to read.
fc = channel.getFileChannel();
- bc = null; // readonly
Review Comment:
why ermoving this line ?
in this code path writeHeader has not been called and bc is already null
setting it to null here is useful to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
