jiazhai commented on code in PR #4333:
URL: https://github.com/apache/bookkeeper/pull/4333#discussion_r1590614411
##########
docker/Dockerfile:
##########
@@ -61,13 +62,15 @@ RUN set -x \
&& tar -xzf "$DISTRO_NAME.tar.gz" \
&& mv bookkeeper-server-${BK_VERSION}/ /opt/bookkeeper/ \
&& rm -rf "$DISTRO_NAME.tar.gz" "$DISTRO_NAME.tar.gz.asc"
"$DISTRO_NAME.tar.gz.sha512" \
- && pip install zk-shell \
- && JAVA_HOME=$(dirname $(dirname $(readlink -f $(which java)))) \
- && echo networkaddress.cache.ttl=1 >>
$JAVA_HOME/conf/security/java.security \
- && echo networkaddress.cache.negative.ttl=1 >>
$JAVA_HOME/conf/security/java.security
+ && pip install zk-shell
WORKDIR /opt/bookkeeper
+ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-$TARGETARCH
Review Comment:
Agree with @zhiheng123 , it is better not using hardcode version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
