sherlock-lin commented on PR #4359: URL: https://github.com/apache/bookkeeper/pull/4359#issuecomment-2105663601
> Looks good, I have two advice: > > * I think `migrate` might be better than `Upgrade`, WDYT? > * As we have many tests, we should point on which part of tests are migrated in PR title. It's better to do like `Migrate All client tests to junit5`, or `Migrate xxxx module tests to junit5` That's good advice, I'll make the adjustments！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
