TakaHiR07 opened a new issue, #4373: URL: https://github.com/apache/bookkeeper/issues/4373
**BUG REPORT** ***Describe the bug*** When upgrade bookie to new version. We found that bookie lost some metrics of OrderedExecutor. The problem is caused after https://github.com/apache/bookkeeper/pull/3546 The root cause is : if we enable traceTaskExecution, SingleThreadExecutor would do addExecutorDecorators(). Then it can't go through the judge `if (thread instanceof SingleThreadExecutor)`   After diving into the code. I found that there are several areas need to be improved in OrderedExecutor and SingleThreadExecutor. 1. fix the lost metrics 2. no need to keep the code relevant to `if (thread instanceof ThreadPoolExecutor)`. This part of code never trigger 3. SingleThreadExecutor#registerMetrics register duplicate metric. This is redundant 4. SingleThreadExecutor#registerMetrics use different format to register metric, which is different from the previous version. I think it's better the keep the previous metric format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
