TakaHiR07 commented on code in PR #4374:
URL: https://github.com/apache/bookkeeper/pull/4374#discussion_r1615546608
##########
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/OrderedExecutor.java:
##########
@@ -391,6 +391,10 @@ protected OrderedExecutor(String baseName, int numThreads,
ThreadFactory threadF
ExecutorService thread = createSingleThreadExecutor(
new ThreadFactoryBuilder().setNameFormat(name + "-" +
getClass().getSimpleName() + "-" + i + "-%d")
.setThreadFactory(threadFactory).build());
+ SingleThreadExecutor ste = null;
+ if (thread instanceof SingleThreadExecutor) {
Review Comment:
Do you mean that remove the check `if (thread instanceof
SingleThreadExecutor)` directly ?
But createSingleThreadExecutor() is also triggered in OrderedScheduler. In
OrderedScheduler, createSingleThreadExecutor() do not return
SingleThreadExecutor, so I keep the check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
