lhotari commented on PR #4404:
URL: https://github.com/apache/bookkeeper/pull/4404#issuecomment-2136298822

   > Thank you for the detailed PR. Since Netty is an active project, do you 
think it would be possible to get confirmation from the Netty project team?
   
   What would you think that should be confirmed?
   
   The javadoc already provides a recommendation:
   > The 
[FlushConsolidationHandler](https://netty.io/4.1/api/io/netty/handler/flush/FlushConsolidationHandler.html)
 should be put as first 
[ChannelHandler](https://netty.io/4.1/api/io/netty/channel/ChannelHandler.html) 
in the 
[ChannelPipeline](https://netty.io/4.1/api/io/netty/channel/ChannelPipeline.html)
 to have the best effect.
   
   I could test another change where I the SslHandler is added after the 
FlushConsolidationHandler instead of removing the handler during the handshake. 
As I mentioned in the description, the actual root cause might still be hidden, 
but this change definitely improves the situation since the reproducer 
https://github.com/lhotari/pulsar-playground/tree/master/issues/issue22601/standalone_env
 won't reproduce with this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to