ange-k opened a new pull request, #4478: URL: https://github.com/apache/bookkeeper/pull/4478
### Motivation `RackawareEnsemblePlacementPolicyImpl.reorderReadSequence` has a feature to sort Bookies with poor performance. Currently, the code checks the entire Ensemble for unavailable Bookies and performs reordering if any are found. However, since the sorting is done within the WriteSet, checking the Ensemble is overkill (except when the sizes are the same). This change modifies the code to check and reorder only the Bookies within the WriteSet. Since the Bookies that are read from are ultimately selected from the WriteSet, there is no need to check the entire Ensemble, which can be misleading to readers of the code. By focusing the checks on the WriteSet, future developers will be able to understand the logic more easily without wondering if there is a specific reason for checking the entire Ensemble. ### Changes - Modified `RackawareEnsemblePlacementPolicyImpl.reorderReadSequence` to check and reorder only the Bookies within the WriteSet instead of the entire Ensemble. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
