liudezhi2098 commented on PR #4482: URL: https://github.com/apache/bookkeeper/pull/4482#issuecomment-2295603491
> Thank you for the contribution! Is this the only place where this needs to be changed? If there are multiple instances, would it make more sense to implement a `toString()` method for the ensemble? toString is used for other purposes, so considering the minimum change, this method is not adjusted. https://github.com/apache/bookkeeper/blob/f048e7a3b127cfa3a7e9761d589225f078d6712c/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/TopologyAwareEnsemblePlacementPolicy.java#L494-L498 comparison with other places has not found any need for adjustment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
