hangc0276 commented on code in PR #4481:
URL: https://github.com/apache/bookkeeper/pull/4481#discussion_r1721182862
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java:
##########
@@ -1462,6 +1468,13 @@ public void close() throws BKException,
InterruptedException {
if (!scheduler.awaitTermination(10, TimeUnit.SECONDS)) {
LOG.warn("The scheduler did not shutdown cleanly");
}
+
+ // Close the watchTask scheduler
+ highPriorityTaskExecutor.shutdown();
+ if (!highPriorityTaskExecutor.awaitTermination(10, TimeUnit.SECONDS)) {
+ LOG.warn("The highPriorityTaskExecutor for WatchTask did not
shutdown cleanly");
Review Comment:
We need call highPriorityTaskExecutor.shutdownNow()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
