lhotari commented on code in PR #4464: URL: https://github.com/apache/bookkeeper/pull/4464#discussion_r1726884919
########## docker/Dockerfile: ########## @@ -86,6 +86,13 @@ COPY --from=jre-build /javaruntime $JAVA_HOME COPY scripts /opt/bookkeeper/scripts RUN chmod +x -R /opt/bookkeeper/scripts/ +RUN chown -R 10000:0 /opt/bookkeeper +RUN chmod -R ug+rwx /opt/bookkeeper +RUN chmod -R g+rx /opt/bookkeeper/bin +RUN chmod -R g+rx /opt/bookkeeper/scripts Review Comment: > When we build the image, we need to use `--squash` feature, this can help us to reduce the intermediate image. squashing is deprecated. ########## docker/Dockerfile: ########## @@ -86,6 +86,13 @@ COPY --from=jre-build /javaruntime $JAVA_HOME COPY scripts /opt/bookkeeper/scripts RUN chmod +x -R /opt/bookkeeper/scripts/ +RUN chown -R 10000:0 /opt/bookkeeper +RUN chmod -R ug+rwx /opt/bookkeeper +RUN chmod -R g+rx /opt/bookkeeper/bin +RUN chmod -R g+rx /opt/bookkeeper/scripts Review Comment: > I tried to use the multi-staged, but the image size has not changed. what did you try? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
