equanz commented on PR #4533: URL: https://github.com/apache/bookkeeper/pull/4533#issuecomment-2531395937
@dlg99 I created the new submodule `native-library-common` and try to add it to shade target. I'm not sure why `native-io` is not shaded, but I only added `native-library-common`. In my understanding, `native-library-common` (and guava) is imported even if shaded beacuse `native-io` requires it. To avoid this issue, for example, shade `native-io` as well, or create a class for `native-io` like https://github.com/apache/bookkeeper/pull/4533/commits/7131e519114cc696009ebe272c3d987985605520 . What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
