StevenLuMT commented on code in PR #4472:
URL: https://github.com/apache/bookkeeper/pull/4472#discussion_r1957208394
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageStats.java:
##########
@@ -85,16 +85,16 @@ class DbLedgerStorageStats {
private final OpStatsLogger readEntryStats;
@StatsDoc(
name = READ_ENTRY_LOCATIONS_INDEX_TIME,
- help = "time spent reading entries from the locations index of the
db ledger storage engine",
+ help = "operation stats of reading entries from the locations
index of the db ledger storage engine",
parent = READ_ENTRY
)
- private final Counter readFromLocationIndexTime;
+ private final OpStatsLogger readFromLocationIndexTime;
@StatsDoc(
name = READ_ENTRYLOG_TIME,
- help = "time spent reading entries from the entry log files of the
db ledger storage engine",
+ help = "operation stats of reading entries from the entry log
files of the db ledger storage engine",
parent = READ_ENTRY
)
- private final Counter readFromEntryLogTime;
+ private final OpStatsLogger readFromEntryLogTime;
Review Comment:
Break change for metric readFromEntryLogTime, I think this may need to send
the mail vote. @eolivelli @dlg99 , please help evaluate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
