lhotari commented on PR #4243: URL: https://github.com/apache/bookkeeper/pull/4243#issuecomment-2701170760
@AnonHxy Another issue that I noticed in closing the RocksDB database is that it's not closing the database properly. The javadoc of org.rocksdb.RocksDB#close says: "This will not fsync the WAL files. If syncing is required, the caller must first call syncWal() or write(WriteOptions, WriteBatch) using an empty write batch with WriteOptions.setSync(boolean) set to true." Would it make sense to also take this into account by adding `db.syncWal()` just after `closed = true;`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
