merlimat commented on issue #4558: URL: https://github.com/apache/bookkeeper/issues/4558#issuecomment-2701476310
> I checked the code in KeyValueStorageRocksDB and there doesn't seem to be a solution to prevent calling count() after the storage is closed. Yes, I think we need to stop the gauge when the object is closed, otherwise it will continue > When looking at the close implementation, I noticed that before closing, the RocksDB WAL isn't flushed with fsync. There seems to be another issue where a graceful shutdown isn't performed for RocksDb when running with BookKeeper. We don't rely on flushing the wal on close. We don't care about wal, because we already rely on the BK journal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
