nodece commented on PR #4588: URL: https://github.com/apache/bookkeeper/pull/4588#issuecomment-2814492996
> There is nothing wrong with the code, but it is recommended to add a testcase to cover this fix @nodece @StevenLuMT Thanks for the suggestion. The fix is in `BookieImpl.java`, which is a core class that's already covered by multiple existing tests. Since the logic is indirectly exercised through various integration and unit tests, adding a separate test might be meaningless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
