merlimat commented on code in PR #4609:
URL: https://github.com/apache/bookkeeper/pull/4609#discussion_r2116227489
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AddCompletion.java:
##########
@@ -0,0 +1,130 @@
+package org.apache.bookkeeper.proto;
+
+import io.netty.util.Recycler;
+import org.apache.bookkeeper.client.BKException;
+import org.apache.bookkeeper.net.BookieId;
+import org.slf4j.MDC;
+
+class AddCompletion extends CompletionValue implements
BookkeeperInternalCallbacks.WriteCallback {
Review Comment:
Refactoring by pulling the classes out masks the actual fix here. Can you,
for this fix, leave the refactoring aside?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
