StevenLuMT commented on code in PR #4643:
URL: https://github.com/apache/bookkeeper/pull/4643#discussion_r2244153035
##########
bookkeeper-common-allocator/src/main/java/org/apache/bookkeeper/common/allocator/impl/ByteBufAllocatorImpl.java:
##########
@@ -140,7 +140,7 @@ public ByteBuf buffer(int initialCapacity) {
@Override
public ByteBuf buffer(int initialCapacity, int maxCapacity) {
- if (poolingPolicy == PoolingPolicy.PooledDirect) {
+ if (poolingPolicy == PoolingPolicy.PooledDirect || poolingPolicy ==
PoolingPolicy.UnpooledDirect) {
Review Comment:
PooledDirect and UnpooledDirect have the same implementation logic, so
what's the point of adding this enumeration? I don't quite understand the
purpose of your change.
Also, for the new types, I suggest adding testcase coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
