liangyepianzhou commented on code in PR #4652:
URL: https://github.com/apache/bookkeeper/pull/4652#discussion_r2278116512
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -364,16 +364,16 @@ protected Set<BookieId>
addDefaultRackBookiesIfMinNumRacksIsEnforced(
Set<BookieId> bookiesInDefaultRack = null;
Set<Node> defaultRackLeaves = topology.getLeaves(getDefaultRack());
for (Node node : defaultRackLeaves) {
- if (node instanceof BookieNode) {
+ if (node instanceof BookieNode && ((BookieNode)
node).getAddr() != null) {
Review Comment:
This simply adds a bounds check, but it seems unnecessary; `addr` shouldn't
be null.
This wasn't a major change and has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
