lhotari commented on PR #4728: URL: https://github.com/apache/bookkeeper/pull/4728#issuecomment-4056295330
Although this fixes the flaky tests, there are multiple remaining race conditions in the auditor which could make it inoperational. For example, this doesn't look right for all cases: https://github.com/apache/bookkeeper/blob/2eb70b1f8216b2c6621d0e57cd491a2067824316/bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationClient.java#L132-L139 This is also surprising: https://github.com/apache/bookkeeper/blob/2eb70b1f8216b2c6621d0e57cd491a2067824316/bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationClient.java#L422-L427 If the first time fails, registering the watcher would be silently ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
