lhotari commented on code in PR #4706: URL: https://github.com/apache/bookkeeper/pull/4706#discussion_r2973168766
########## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java: ########## Review Comment: a minor detail is that `columnFamilyDescriptors` aren't closed. I'd assume that it leaks a tiny bit of memory in cases where the JVM process wouldn't terminate (most likely only in test scenarios). I'm not exactly sure about this. It's not a blocker for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
