merlimat opened a new pull request, #4744:
URL: https://github.com/apache/bookkeeper/pull/4744
## Summary
Upgrades Netty from `4.1.130.Final` to `4.2.12.Final` (latest 4.2.x). This
upgrade is needed to enable upgrading the `async-http-client` library, which
has switched to Netty 4.2 and is no longer compatible with 4.1.
### Key changes
- **Netty version**: `4.1.130.Final` → `4.2.12.Final`, removed separate
`netty-iouring.version` since io_uring transport is now part of the main Netty
release
- **io_uring migration**: Package `io.netty.incubator.channel.uring` →
`io.netty.channel.uring`, class naming convention `IOUring*` → `IoUring*`. The
`IOUringEventLoopGroup` class was removed in 4.2 and is replaced by
`MultiThreadIoEventLoopGroup(IoUringIoHandler.newFactory())`
- **Epoll classes split**: Netty 4.2 split epoll into
`netty-transport-classes-epoll` (pure Java) + `netty-transport-native-epoll`
(native binaries); added the explicit classes dependency in
`bookkeeper-server/pom.xml`
- **EventLoopUtil helper**: Added `isIoUringGroup(EventLoopGroup)` that uses
`MultiThreadIoEventLoopGroup.isIoType(IoUringIoHandler.class)` since
`instanceof IOUringEventLoopGroup` is no longer possible
- **LICENSE/NOTICE files** in `bookkeeper-dist` updated to reflect new
artifact names (`netty-codec` was split into `netty-codec-base` /
`netty-codec-compression`, io_uring moved from `io.netty.incubator` to
`io.netty`, `netty-tcnative-boringssl-static` 2.0.74 → 2.0.75)
`EpollEventLoopGroup` and `NioEventLoopGroup` are now deprecated in favor of
`MultiThreadIoEventLoopGroup` with factories, but remain functional; this PR
keeps using them to minimize surface area of the change.
## Test plan
- [x] `mvn install -DskipTests` — full build succeeds
- [x] `mvn -pl bookkeeper-dist/{server,all,bkctl} -am package` — all three
distribution bundles build successfully
- [x] `TestPerChannelBookieClient` + `ClientSocketDisconnectTest` — pass
- [x] `BookieInitializationTest` (40 tests) — pass
- [ ] CI full test suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
