lhotari commented on code in PR #4738:
URL: https://github.com/apache/bookkeeper/pull/4738#discussion_r3085909358


##########
.github/workflows/bk-ci.yml:
##########
@@ -82,6 +82,22 @@ jobs:
           distribution: 'temurin'
           java-version: 17
 
+      - name: Set up Rust
+        uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+        with:
+          # Cross-compilation targets: Linux amd64 and arm64 (glibc)
+          targets: >-
+            x86_64-unknown-linux-gnu,
+            aarch64-unknown-linux-gnu
+
+      - name: Set up Zig
+        if: steps.check_changes.outputs.docs_only != 'true'
+        uses: mlugg/setup-zig@d1434d08867e3ee9daa34448df10607b98908d29
+
+      - name: Install cargo-zigbuild
+        if: steps.check_changes.outputs.docs_only != 'true'
+        run: cargo install --locked cargo-zigbuild
+

Review Comment:
   since this block gets duplicated in all workflows, it's better to create an 
inline composite action to `.github/actions` inside the repository, an example 
in Pulsar: 
https://github.com/apache/pulsar/blob/master/.github/actions/setup-gradle/action.yml
 . I guess the action name could be called `setup-native-build`.
   It can be referenced in a workflow 
   
   ```
         - name: Setup native build
           uses: ./.github/actions/setup-native-build
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to